-
Notifications
You must be signed in to change notification settings - Fork 10
Updated coda/mina python client #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…le get_blocks method, adjust/update docstrings, reformat file
|
This is wonderful! Thanks for doing that @bakebrain. I will poke someone to try and get this merged! |
|
Also, I would recommend doing the coda -> mina rename if you have the spare cycles! |
|
|
…by_state_hash, tests + more cleanups
|
@yourbuddyconner refactored "coda" to "mina" |
|
Love it, I will do some testing from your branch on the new testnet today. Thanks for putting in the work it is appreciated. |
|
Thx for looking into it - plz let me know what you would like to change! I also have this notebook to play with the client: https://github.com/bakebrain/coda-python-client/blob/mina-play/mina_client_playground.ipynb |
|
The @bakebrain do you have discord and/or twitter? |
|
@yourbuddyconner added the peer info! |
…fields, fixed subsciptions
Updated coda/mina python client
Description
During the process of developing python monitoring tools for the mina node I realised that some of the queries hardcoded in the minas/coda python client were not update to the latest graphql schema. This included default methods like
get_daemon_statusorget_sync_status. I have updated all the queries to work with the latest schema to work with my scripts - and in the process I decided to create this pull request - also fixing all the broken tests, update/clean/align doc-strings and overall formats of the files (the default yapf chromium style is also deprecated by now). I have tested all queries with my node currently running latest devnet [DIRTY]8dfa4837f72c9c4d8a4daa3d416d9c852619fbb4.Open questions
I have a couple questions regarding this though
get_blockssince the needed data is not part of the schema any longer - they are now available via @garethtdavies minaexplorer endpoint. Is this wrapper supposed to support those queries going forward?TODOS
listen_block_confirmations- not 100% sure how to do that at this point tbhI am happy to contribute more to this part - plz let me know what could be a priority or needs attention!